Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix server IP in info panel #417

Closed

Conversation

petrparolek
Copy link

@petrparolek petrparolek commented Apr 15, 2020

closes #416

  • bug fix

  • BC break? no

  • doc PR: nette/docs will be

@dg dg force-pushed the master branch 4 times, most recently from e366355 to 4c3f344 Compare Apr 16, 2020
src/Tracy/Debugger/Debugger.php Outdated Show resolved Hide resolved
src/Tracy/Debugger/Debugger.php Outdated Show resolved Hide resolved
src/Tracy/Bar/panels/info.panel.phtml Outdated Show resolved Hide resolved
src/Tracy/Bar/panels/info.panel.phtml Outdated Show resolved Hide resolved
@petrparolek petrparolek force-pushed the 416-improved-ip-detection branch from 87cfc94 to c47e0d6 Compare Apr 16, 2020
@petrparolek
Copy link
Author

petrparolek commented Apr 16, 2020

@dg why there a lo of your commits?

@janbarasek
Copy link
Contributor

janbarasek commented Apr 16, 2020

@petrparolek Please merge current master to your branch. Your branch contains 47 changed files. There are so many...

@petrparolek
Copy link
Author

petrparolek commented Apr 16, 2020

I don't know why @dg force pushed to master!

@janbarasek
Copy link
Contributor

janbarasek commented Apr 16, 2020

@petrparolek Please be polite to David. You want merge your changes, you must fix conflict! :)

@petrparolek petrparolek force-pushed the 416-improved-ip-detection branch from c47e0d6 to d8f8d27 Compare Apr 16, 2020
@petrparolek
Copy link
Author

petrparolek commented Apr 16, 2020

I made commit again

@janbarasek
Copy link
Contributor

janbarasek commented Apr 16, 2020

@petrparolek Thanks, but please fix codestyle and tests first.

src/Tracy/Bar/panels/info.panel.phtml Outdated Show resolved Hide resolved
src/Tracy/Bar/panels/info.panel.phtml Outdated Show resolved Hide resolved
@petrparolek
Copy link
Author

petrparolek commented Apr 16, 2020

tests are falling because of last commit from @dg

@petrparolek petrparolek force-pushed the 416-improved-ip-detection branch from d8f8d27 to c74b877 Compare Apr 16, 2020
@janbarasek
Copy link
Contributor

janbarasek commented Apr 16, 2020

@petrparolek Ok, thanks. Who define value of public property $behindProxy?

Can you implement autodetection?

What happen when real user IP (before proxy) is fake?

@petrparolek
Copy link
Author

petrparolek commented Apr 16, 2020

I think autodection is not possible, in default mode tracy show IP address as in version 2.6.3 and user can switch to your solution by Debugger::$behindProxy = true;, if @dg agree with solution, we can add Debugger::$behindProxy = true; to doc and to DI extension

@dg
Copy link
Member

dg commented Apr 16, 2020

Sorry for force push.

Hey boys we are talking about a totally irrelevant thing hidden somewhere in the panel. Spoofing doen't matter, you would have to spoof yourself. Adding a new configuration variable to the Debugger is an inadequate solution.

I suggest to remove this item from the info panel :-)

@petrparolek
Copy link
Author

petrparolek commented Apr 16, 2020

@dg I suggest to revert whole comnmit ce31ae5 and close this PR.

@dg dg closed this Apr 18, 2020
dg added a commit that referenced this pull request Apr 18, 2020
dg added a commit that referenced this pull request Apr 21, 2020
dg added a commit that referenced this pull request Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong IP address in info panel
3 participants