-
-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix server IP in info panel #417
Conversation
e366355
to
4c3f344
Compare
87cfc94
to
c47e0d6
Compare
@dg why there a lo of your commits? |
@petrparolek Please merge current master to your branch. Your branch contains 47 changed files. There are so many... |
I don't know why @dg force pushed to master! |
@petrparolek Please be polite to David. You want merge your changes, you must fix conflict! :) |
c47e0d6
to
d8f8d27
Compare
I made commit again |
@petrparolek Thanks, but please fix codestyle and tests first. |
tests are falling because of last commit from @dg |
d8f8d27
to
c74b877
Compare
@petrparolek Ok, thanks. Who define value of public property Can you implement autodetection? What happen when real user IP (before proxy) is fake? |
I think autodection is not possible, in default mode tracy show IP address as in version 2.6.3 and user can switch to your solution by |
Sorry for force push. Hey boys we are talking about a totally irrelevant thing hidden somewhere in the panel. Spoofing doen't matter, you would have to spoof yourself. Adding a new configuration variable to the Debugger is an inadequate solution. I suggest to remove this item from the info panel :-) |
closes #416
bug fix
BC break? no
doc PR: nette/docs will be