Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bar.js: fetch checks Response #420

Merged
merged 1 commit into from May 15, 2020
Merged

bar.js: fetch checks Response #420

merged 1 commit into from May 15, 2020

Conversation

HamAndRock
Copy link
Contributor

@HamAndRock HamAndRock commented May 15, 2020

In project I am currently working on, I also wrap fetch() method and return the result as json object, but tracy doesn't check if the response is actually a Response object.

So it thinks my json object is Response object and tries to access .headers property, that may not exist and then run function has() on it.

  • bug fix
  • BC break? no

In project I am currently working on, I also wrap fetch() method and return the result as json object, but tracy doesn't check if the response is actually a Response object.

So it thinks my json object is response and tries to access .headers propery, that may not exist and then run function has on it.
@dg dg force-pushed the master branch 2 times, most recently from a913052 to 8ee82e8 Compare May 15, 2020
@dg
Copy link
Member

@dg dg commented May 15, 2020

Thanks

@dg dg changed the title Custom fetch fix bar.js: fetch checks Response May 15, 2020
@dg dg merged commit a5f6ee3 into nette:master May 15, 2020
2 of 3 checks passed
dg pushed a commit that referenced this issue May 15, 2020
dg pushed a commit that referenced this issue May 16, 2020
dg pushed a commit that referenced this issue May 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants