bar.js: fetch checks Response #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In project I am currently working on, I also wrap fetch() method and return the result as json object, but tracy doesn't check if the response is actually a Response object. So it thinks my json object is response and tries to access .headers propery, that may not exist and then run function has on it.
dg
force-pushed
the
master
branch
2 times, most recently
from
a913052
to
8ee82e8
Compare
|
Thanks |
dg
pushed a commit
that referenced
this pull request
May 15, 2020
dg
pushed a commit
that referenced
this pull request
May 16, 2020
dg
pushed a commit
that referenced
this pull request
May 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In project I am currently working on, I also wrap
fetch()method and return the result asjsonobject, but tracy doesn't check if the response is actually a Response object.So it thinks my json object is
Responseobject and tries to access.headersproperty, that may not exist and then run functionhas()on it.