Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Info panel JIT #440

Merged
merged 1 commit into from Oct 14, 2020
Merged

Info panel JIT #440

merged 1 commit into from Oct 14, 2020

Conversation

MikyWoW
Copy link
Contributor

@MikyWoW MikyWoW commented Oct 2, 2020

  • new feature
  • BC break? no

PHP 8 is supports JIT. Would be nice to show if its enabled.

PHP 8 is supports JIT. Would be nice to show if its enabled.
@dg dg force-pushed the master branch 8 times, most recently from 55360f2 to 867c2b6 Compare Oct 13, 2020
@dg dg force-pushed the master branch 6 times, most recently from 76bd58c to b9d29d3 Compare Oct 14, 2020
@dg
Copy link
Member

dg commented Oct 14, 2020

Thanks

@dg dg marked this pull request as ready for review Oct 14, 2020
@dg dg merged commit a2951f1 into nette:master Oct 14, 2020
1 of 2 checks passed
dg pushed a commit that referenced this pull request Oct 14, 2020
dg pushed a commit that referenced this pull request Oct 14, 2020
@diegosardina
Copy link

Error: Tracy:info
DivisionByZeroError: Division by zero in [...]/vendor/tracy/tracy/src/Tracy/Bar/panels/info.panel.phtml:47

This should be improved a bit more, because the default configuration and behavior is weird.

Jit is enabled by default (in tracing), but buffer_size is 0 (that is its default value) and the zero value disables JIT. Then JIT is not enabled although $opcache['jit']['enabled'] is true.

It should be enough to check for $jit['buffer_size'] > 0

@dg
Copy link
Member

dg commented Dec 8, 2020

@diegosardina I tried to fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants