Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BlueScreen: Render actions can fail. #497

Closed
wants to merge 1 commit into from
Closed

BlueScreen: Render actions can fail. #497

wants to merge 1 commit into from

Conversation

janbarasek
Copy link
Contributor

@janbarasek janbarasek commented Jun 23, 2021

  • bug fix
  • BC break? no

If a fatal autoloader error is thrown, no bluescreen is displayed (or logged) because the renderActions() method internally verifies the nonexistence of a class that may recursively fail due to an autoloader.

For example:

Snímek obrazovky 2021-06-23 v 17 19 32

In the log you can then (under certain circumstances) see all the way through Tracy:

Snímek obrazovky 2021-06-23 v 17 20 20

Snímek obrazovky 2021-06-23 v 17 21 47

It is only when the internal exception throwing is handled that we learn the real error (which has otherwise been discarded):

Snímek obrazovky 2021-06-23 v 17 21 26

Thanks.

janbarasek added a commit to baraja-core/plugin-system that referenced this pull request Jun 23, 2021
@dg dg closed this in 0e9fb31 Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant