Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compatibility with PHP 8 after "Treat namespaced names as single token" RFC #229

Closed
ondrejmirtes opened this issue Jul 29, 2020 · 1 comment
Closed

Fix compatibility with PHP 8 after "Treat namespaced names as single token" RFC #229

ondrejmirtes opened this issue Jul 29, 2020 · 1 comment

Comments

@ondrejmirtes
Copy link
Contributor

Version: nette/utils master on PHP 8 nightly

This RFC breaks Reflection class: https://wiki.php.net/rfc/namespaced_names_as_token
This is how the tests fail: https://github.com/ondrejmirtes/utils/runs/924516761?check_suite_focus=true#step:5:54

This is a proof-of-concept fix: ondrejmirtes@e55a8da

I'd send a PR but there are other build failures I'm not sure how you want fixed. Feel free to check out my branch: https://github.com/ondrejmirtes/utils/commits/php-8
@dg dg closed this as completed in b6414bc Jul 30, 2020
@dg
Copy link
Member

dg commented Jul 30, 2020

Merged, thanks

dg pushed a commit that referenced this issue Jul 30, 2020
@ondrejmirtes @dg
Reflection: fixed parseUseStatements for PHP 8 [Closes #229]
695fe07
dg pushed a commit that referenced this issue Jul 30, 2020
@ondrejmirtes @dg
Reflection: fixed parseUseStatements for PHP 8 [Closes #229]
a55cb8d
dg pushed a commit that referenced this issue Jul 30, 2020
@ondrejmirtes @dg
Reflection: fixed parseUseStatements for PHP 8 [Closes #229]
03db1de
dg pushed a commit that referenced this issue Jul 31, 2020
@ondrejmirtes @dg
Reflection: fixed parseUseStatements for PHP 8 [Closes #229]
f8cce05
dg pushed a commit that referenced this issue Aug 3, 2020
@ondrejmirtes @dg
Reflection: fixed parseUseStatements for PHP 8 [Closes #229]
917fc6c
dg pushed a commit that referenced this issue Nov 5, 2020
@ondrejmirtes @dg
Reflection: fixed parseUseStatements for PHP 8 [Closes #229]
b497f54
dg pushed a commit that referenced this issue Nov 5, 2020
@ondrejmirtes @dg
Reflection: fixed parseUseStatements for PHP 8 [Closes #229]
f47ebc2
dg pushed a commit that referenced this issue Nov 5, 2020
@ondrejmirtes @dg
Reflection: fixed parseUseStatements for PHP 8 [Closes #229]
57e05ea
dg pushed a commit that referenced this issue Nov 5, 2020
@ondrejmirtes @dg
Reflection: fixed parseUseStatements for PHP 8 [Closes #229]
36e69ae
dg pushed a commit that referenced this issue Nov 5, 2020
@ondrejmirtes @dg
Reflection: fixed parseUseStatements for PHP 8 [Closes #229]
3b3fcb7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ondrejmirtes @dg