Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added removeAttributes method - removing multiple attributes #161

Merged
merged 2 commits into from Feb 6, 2018
Merged

Added removeAttributes method - removing multiple attributes #161

merged 2 commits into from Feb 6, 2018

Conversation

Machy8
Copy link
Contributor

@Machy8 Machy8 commented Jan 17, 2018

  • bug fix? no
  • new feature? yes

Description

  • Added method removeAttributes for removing multiple attributes
  • Why: for example when converting html element to the Amp html element, sometimes is necessary to remove multiple (by Amp disabled) attributes like frameborder, allowfullscreen or scrolling
  • There is already a method for setting multiple attributes but non for removing multiple attributes so it means to create loops in order to remove them

@dg
Copy link
Member

@dg dg commented Feb 6, 2018

Thanks

@dg dg merged commit 365fe6b into nette:master Feb 6, 2018
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants