-
-
Notifications
You must be signed in to change notification settings - Fork 151
Arrays: added wrap() method #180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milo
pushed a commit
to milo/nette-utils
that referenced
this pull request
Dec 7, 2018
Member
Author
|
Maybe implement it by count($arr) ? ($prefix . implode($suffix . $glue . $prefix, $arr) . $suffix) : '';but crucial is an API. No need for array count condition and prefix/suffix on single place. |
1d615d6 to
ec1e405
Compare
5c076fd to
0b71017
Compare
Member
|
What about method |
3ad8f46 to
c133e18
Compare
4ed28bc to
7331c07
Compare
2255a73 to
7a754e0
Compare
1113bc3 to
7a71315
Compare
f3d5f78 to
d0427c1
Compare
740520b to
2bc2f58
Compare
Member
Author
|
Sure, Not sure about type casting everything to string. |
Member
|
Great |
Member
Author
|
Thank you! |
dg
pushed a commit
that referenced
this pull request
Jan 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using such conctruction quite often, maybe I'm not the only one.