Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileSystem: Add method makeWritable() #244

Merged
merged 4 commits into from Aug 16, 2021
Merged

FileSystem: Add method makeWritable() #244

merged 4 commits into from Aug 16, 2021

Conversation

janbarasek
Copy link
Contributor

@janbarasek janbarasek commented Jan 5, 2021

  • new feature
  • BC break? no

Very often I need to write to a directory where I cannot guarantee the correctly set permissions in advance.

This feature can try to fix the permissions according to the settings, or throw an exception.

Directory permissions are set recursively.

@JanTvrdik
Copy link
Contributor

  1. fix permission is bad name; it should be called changePermissions (with removal of default values for $dirMode and $fileMode) or makeWritable (and keep the default values)
  2. i'm not sure if you need the $recursive parameter as everything in FileSytem is always recursive

@janbarasek janbarasek changed the title FileSystem: Add method fixPermissions(). FileSystem: Add method makeWritable(). Jan 5, 2021
@janbarasek
Copy link
Contributor Author

@JanTvrdik Fixed, thanks.

@dg dg changed the title FileSystem: Add method makeWritable(). FileSystem: Add method makeWritable() Aug 16, 2021
@dg dg merged commit 1d3a574 into nette:master Aug 16, 2021
dg pushed a commit that referenced this pull request Aug 16, 2021
dg pushed a commit that referenced this pull request Aug 16, 2021
dg pushed a commit that referenced this pull request Aug 16, 2021
dg pushed a commit that referenced this pull request Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants