Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConnectionHelper alias #10

Merged
merged 1 commit into from May 7, 2018

Conversation

2 participants
@uestla
Copy link
Contributor

uestla commented May 6, 2018

Current ^2.6 version of ImportCommand in doctrine/dbal requires the connection helper to be aliased with "db":

https://github.com/doctrine/dbal/blob/3591db5a402bbcf255e35441d0f150fde44c64ba/lib/Doctrine/DBAL/Tools/Console/Command/ImportCommand.php#L62-L65

Nettrine\DBAL\DI\DbalConsoleExtension however does not do that - it only registers the helper without any alias:

// Register helpers
$connectionHelper = $this->prefix('@connectionHelper');
$application->addSetup(new Statement('$service->getHelperSet()->set(?)', [$connectionHelper]));


This causes the usage of dbal:import command impossible leading it to error

The helper "db" is not defined.

This PR adds the alias.

@f3l1x f3l1x merged commit b9a7011 into nettrine:master May 7, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 28.488%
Details
@f3l1x

This comment has been minimized.

Copy link
Member

f3l1x commented May 7, 2018

Awesome, thanks.

@f3l1x f3l1x added the enhancement label May 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.