Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DbalConsoleExtension: accept %consoleMode% in constructor #16

Merged
merged 1 commit into from Jun 18, 2018

Conversation

2 participants
@jiripudil
Copy link
Contributor

jiripudil commented Jun 17, 2018

The extension in contributte/console requires %consoleMode% in constructor, and skips any configuration if it evaluates to false. However, the code here depends on PHP_SAPI, resulting in an exception in environments where PHP_SAPI === 'cli', but consoleMode === false (namely integration tests).

This PR unifies this behaviour and allows users to provide %consoleMode% in constructor as well, in a backward-compatible way.

@f3l1x f3l1x merged commit c3ed16d into nettrine:master Jun 18, 2018

1 of 2 checks passed

coverage/coveralls Coverage decreased (-0.6%) to 29.722%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@f3l1x

This comment has been minimized.

Copy link
Member

f3l1x commented Jun 18, 2018

Thanks.

@f3l1x f3l1x added this to the v0.3 milestone Jun 18, 2018

@jiripudil jiripudil deleted the jiripudil:patch-1 branch Jun 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.