Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for XML mapping #42

Merged
merged 5 commits into from Dec 25, 2018

Conversation

2 participants
@JanMikes
Copy link
Contributor

JanMikes commented Dec 4, 2018

Closes #6

@f3l1x code review is appreciated. I have noticed that there is cache for annotation driver (the cache reader), but nothing like that for xml mapping - maybe it is necessary, though i could miss something.

This implementation seems to be so lightweight, maybe it is enough and does not need to be more complicated 馃槃

@f3l1x

This comment has been minimized.

Copy link
Member

f3l1x commented Dec 19, 2018

Hi. Looks awesome.

/** @var mixed[] */
public $defaults = [
'paths' => [], //'%appDir%'

This comment has been minimized.

@f3l1x

f3l1x Dec 19, 2018

Member

By default is paths field empty. So it won't work? What about suggest in readme to put there %appDir% or if paths is empty, fill %appDir% automatically?

This comment has been minimized.

@JanMikes

JanMikes Jan 8, 2019

Author Contributor

Sorry @f3l1x for such a late response, I have completely missed it.

To be honest i just copied this one from https://github.com/nettrine/orm/blob/master/src/DI/OrmAnnotationsExtension.php#L45 and I was not sure why it is in comment 馃槃

@f3l1x f3l1x merged commit fd128d6 into nettrine:master Dec 25, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.