Permalink
Browse files

Add a missing close(SelectionKey) call

* Without calling close(SelectionKey), the client boss loop can fall
into an infinite loop.
  • Loading branch information...
1 parent 0da3990 commit 2a9c5efe8fc7eb3a18a2891dc4505a8cdf6f54c5 @trustin trustin committed Nov 23, 2011
@@ -376,6 +376,7 @@ private void processConnectTimeout(Set<SelectionKey> keys, long currentTimeNanos
ConnectException cause = null;
for (SelectionKey k: keys) {
if (!k.isValid()) {
+ close(k);
continue;
}

4 comments on commit 2a9c5ef

Owner

normanmaurer replied Nov 23, 2011

This sounds like a "major" bug. Would you mind to fill a issue for it an close it ? So we have a better history of what bugs got fixed ?

Owner

trustin replied Nov 23, 2011

Created #74

Owner

normanmaurer replied Nov 23, 2011

Thanks!

According to #138, this fix causes java.nio.channels.ClosedChannelException. I'm also seeing these kind of exceptions in 3.2.7 that did not happen in 3.2.6 before

Please sign in to comment.