Permalink
Show file tree
Hide file tree
4 changes: 2 additions & 2 deletions
4
buffer/src/test/java/io/netty/buffer/AbstractByteBufTest.java
2 changes: 1 addition & 1 deletion
2
buffer/src/test/java/io/netty/buffer/ReadOnlyDirectByteBufferBufTest.java
5 changes: 3 additions & 2 deletions
5
codec-http/src/main/java/io/netty/handler/codec/http/multipart/AbstractDiskHttpData.java
3 changes: 2 additions & 1 deletion
3
codec-http/src/test/java/io/netty/handler/codec/http/HttpChunkedInputTest.java
2 changes: 1 addition & 1 deletion
2
codec-http/src/test/java/io/netty/handler/codec/http/multipart/AbstractDiskHttpDataTest.java
4 changes: 2 additions & 2 deletions
4
...-http/src/test/java/io/netty/handler/codec/http/multipart/AbstractMemoryHttpDataTest.java
2 changes: 1 addition & 1 deletion
2
codec-http/src/test/java/io/netty/handler/codec/http/multipart/DiskFileUploadTest.java
2 changes: 1 addition & 1 deletion
2
common/src/main/java/io/netty/util/internal/NativeLibraryLoader.java
19 changes: 19 additions & 0 deletions
19
common/src/main/java/io/netty/util/internal/PlatformDependent.java
6 changes: 4 additions & 2 deletions
6
handler/src/main/java/io/netty/handler/ssl/util/SelfSignedCertificate.java
3 changes: 2 additions & 1 deletion
3
handler/src/test/java/io/netty/handler/stream/ChunkedWriteHandlerTest.java
3 changes: 2 additions & 1 deletion
3
handler/src/test/java/io/netty/handler/traffic/FileRegionThrottleTest.java
4 changes: 2 additions & 2 deletions
4
testsuite/src/main/java/io/netty/testsuite/transport/socket/SocketFileRegionTest.java
3 changes: 2 additions & 1 deletion
3
transport-native-epoll/src/test/java/io/netty/channel/epoll/EpollSpliceTest.java
3 changes: 2 additions & 1 deletion
3
...ort-native-unix-common-tests/src/main/java/io/netty/channel/unix/tests/UnixTestUtils.java
2 changes: 1 addition & 1 deletion
2
transport/src/test/java/io/netty/channel/DefaultFileRegionTest.java
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
Use Files.createTempFile(...) to ensure the file is created with prop…
…er permissions Motivation: File.createTempFile(String, String)` will create a temporary file in the system temporary directory if the 'java.io.tmpdir'. The permissions on that file utilize the umask. In a majority of cases, this means that the file that java creates has the permissions: `-rw-r--r--`, thus, any other local user on that system can read the contents of that file. This can be a security concern if any sensitive data is stored in this file. This was reported by Jonathan Leitschuh <jonathan.leitschuh@gmail.com> as a security problem. Modifications: Use Files.createTempFile(...) which will use safe-defaults when running on java 7 and later. If running on java 6 there isnt much we can do, which is fair enough as java 6 shouldnt be considered "safe" anyway. Result: Create temporary files with sane permissions by default.
- Loading branch information
1 parent
8f397e2
commit c735357
Showing
16 changed files
with
47 additions
and
20 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters