Skip to content
Permalink
Browse files

Small fixes and improvements

Motivation:

Fix some typos in Netty.

Modifications:

- Fix potentially dangerous use of non-short-circuit logic in Recycler.transfer(Stack<?>).
- Removed double 'the the' in javadoc of EmbeddedChannel.
- Write to log an exception message if we can not get SOMAXCONN in the NetUtil's static block.
  • Loading branch information...
idelpivnitskiy authored and Norman Maurer committed Jul 19, 2014
1 parent dc9d933 commit dd429b249504b8f7c3caa3bcd417696839c6d328
@@ -186,7 +186,7 @@
somaxconn = Integer.parseInt(in.readLine());
logger.debug("/proc/sys/net/core/somaxconn: {}", somaxconn);
} catch (Exception e) {
// Failed to get SOMAXCONN
logger.debug("Failed to get SOMAXCONN", e);
} finally {
if (in != null) {
try {
@@ -236,7 +236,7 @@ boolean transfer(Stack<?> to) {
}
to.size = size;

if (end == LINK_CAPACITY & head.next != null) {
if (end == LINK_CAPACITY && head.next != null) {
this.head = head.next;
}

@@ -163,7 +163,7 @@ public boolean isActive() {
*
* @param msgs the messages to be written
*
* @return {@code true} if the write operation did add something to the the inbound buffer
* @return {@code true} if the write operation did add something to the inbound buffer
*/
public boolean writeInbound(Object... msgs) {
ensureOpen();
@@ -185,7 +185,7 @@ public boolean writeInbound(Object... msgs) {
* Write messages to the outbound of this {@link Channel}.
*
* @param msgs the messages to be written
* @return bufferReadable returns {@code true} if the write operation did add something to the the outbound buffer
* @return bufferReadable returns {@code true} if the write operation did add something to the outbound buffer
*/
public boolean writeOutbound(Object... msgs) {
ensureOpen();

0 comments on commit dd429b2

Please sign in to comment.
You can’t perform that action at this time.