Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Relax "pinning" of custom EventExecutor #1249

Closed
normanmaurer opened this Issue Apr 8, 2013 · 1 comment

Comments

Projects
None yet
1 participant
Owner

normanmaurer commented Apr 8, 2013

At the moment we choose the EventExecutor to use for a ChannelHandler once the DefaultChannelHandlerContext is created and the EventExecutor will stay the same for the whole lifetime.
This can lead to performance problems if other blocking tasks keep it busy but there would be other idle EventExecutor in the EventExecutorGroup ready to use.

I think we should relax the "pinning" a bit to just "obtain" the next "less busy" EventExecutor from the EventGroup and execute the Task. We still need to make sure that the methods of the ChannelHandler are not called concurrently.

Owner

normanmaurer commented May 10, 2013

After thinking more about this this will not work as if we switch between threads it may lead to access cached data which is not updated yet. So let us close this as won't fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment