Correctly keep track of validExtensions per request / response #13180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will try to find some time to write a unit test as well. |
Motivation: At the moment we not correctly reset state between different request / response pairs. This can lead to situations when invalid extensions are used. Modifications: - Use a Queue to keep track of extensions per request / response Result: Fixes #13176
normanmaurer
force-pushed
the
extension_handler
branch
from
a3ee70a
to
7f6f0dd
Compare
normanmaurer
added a commit
that referenced
this pull request
Feb 6, 2023
Motivation: At the moment we not correctly reset state between different request / response pairs. This can lead to situations when invalid extensions are used. Modifications: - Use a Queue to keep track of extensions per request / response Result: Fixes #13176
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
At the moment we not correctly reset state between different request / response pairs. This can lead to situations when invalid extensions are used.
Modifications:
Result:
Fixes #13176