%s WebSocket version %s server handshake #2275

Closed
ngocdaothanh opened this Issue Feb 28, 2014 · 3 comments

2 participants

@ngocdaothanh

1.

In https://github.com/netty/netty/blob/master/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketServerHandshaker.java

logger.debug("%s WebSocket version %s server handshake", channel, version());

I guess it should be:

logger.debug("{} WebSocket version {} server handshake", channel, version());

2.

In https://github.com/netty/netty/blob/master/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketServerHandshaker07.java

logger.debug("WebSocket version 07 server handshake key: {}, response: %s.", key, accept);

I guess it should be:

logger.debug("WebSocket version 07 server handshake key: {}, response: {}.", key, accept);
@normanmaurer
The Netty Project member

@ngocdaothanh would you mind submitting a PR ?

@ngocdaothanh

Sure! I wanted to confirm if my guess was right.

@ngocdaothanh ngocdaothanh pushed a commit to ngocdaothanh/netty that referenced this issue Feb 28, 2014
Dao Ngoc Fix #2275 %s WebSocket version %s server handshake 0423b08
@ngocdaothanh ngocdaothanh pushed a commit to ngocdaothanh/netty that referenced this issue Feb 28, 2014
Dao Ngoc Fix #2275 %s WebSocket version %s server handshake 133440f
@ngocdaothanh ngocdaothanh pushed a commit to ngocdaothanh/netty that referenced this issue Feb 28, 2014
Dao Ngoc Fix #2275 %s WebSocket version %s server handshake ba0d6b6
@ngocdaothanh

I've sent pull requests for branch 4.0, 4.1, and master.

@trustin trustin added a commit that closed this issue Mar 1, 2014
Dao Ngoc Fix #2275 %s WebSocket version %s server handshake 94bcbba
@trustin trustin closed this in 94bcbba Mar 1, 2014
@trustin trustin added a commit that referenced this issue Mar 1, 2014
Dao Ngoc Fix #2275 %s WebSocket version %s server handshake fcc6b54
@trustin trustin added a commit that referenced this issue Mar 1, 2014
Dao Ngoc Fix #2275 %s WebSocket version %s server handshake 98d81b2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment