Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IdleStateHandler/ReadTimeoutHandler/WriteTimeoutHandler should use System.nanoTime() #2301

Closed
normanmaurer opened this issue Mar 11, 2014 · 1 comment
Closed

IdleStateHandler/ReadTimeoutHandler/WriteTimeoutHandler should use System.nanoTime() #2301

normanmaurer opened this issue Mar 11, 2014 · 1 comment
Labels
help wanted improvement
Milestone
4.0.18.Final

Comments

@normanmaurer
Copy link
Member

At the moment all these three use System.currentTimeMillis() which we should change.
@normanmaurer normanmaurer added this to the 4.0.18.Final milestone Mar 11, 2014
@trustin
Copy link
Member

trustin commented Mar 12, 2014

+1

normanmaurer pushed a commit that referenced this issue Mar 14, 2014
[#2301] Replace usage of System.currentTimeMillis() with System.nanoT…
988781f 
…ime()

Motivation:

Currently we use System.currentTimeMillis() in our timeout handlers this is bad
for various reasons like when the clock adjusts etc.

Modifications:

Replace System.currentTimeMillis() with System.nanoTime()

Result:

More robust timeout handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted improvement
Projects
None yet
Milestone
4.0.18.Final
Development

No branches or pull requests
2 participants
@trustin @normanmaurer