Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Http2ConnectionHandler breaks channelReadComplete pipeline notification #3945

Closed
blucas opened this issue Jul 7, 2015 · 4 comments
Closed

Http2ConnectionHandler breaks channelReadComplete pipeline notification #3945

blucas opened this issue Jul 7, 2015 · 4 comments
Assignees
@normanmaurer
Labels
defect
Milestone
4.1.0.Beta6

Comments

@blucas
Copy link
Contributor

blucas commented Jul 7, 2015

Netty Version: 5.0.0-Alpha3-SNAPSHOT

Hi guys,

Http2ConnectionHandler overrides channelReadComplete(...) here but fails to pass notification further down the pipeline by calling super.channelReadComplete(...) or ctx.fireChannelReadComplete(...). I assume it should call super.channelReadComplete(...), what are your thoughts?

/cc @Scottmitch @nmittler @louiscryan as you guys know more about this :)
@normanmaurer
Copy link
Member

@blucas makes sense. We love PRs as you know ;)

@nmittler
Copy link
Member

nmittler commented Jul 7, 2015

+1 to PRs :)

@normanmaurer normanmaurer self-assigned this Jul 7, 2015
@normanmaurer
Copy link
Member

Let me fix this.

@normanmaurer normanmaurer added this to the 4.1.0.Beta6 milestone Jul 7, 2015
normanmaurer added a commit that referenced this issue Jul 7, 2015
@normanmaurer
[#3945] Http2ConnectionHandler breaks channelReadComplete pipeline no…
9760922 
…tification

Motivation:

Http2ConnectionHandler missed to forward channelReadComplete(...) events.

Modifications:

Ensure we notify the next handler in the pipeline via ctx.fireChannelReadComplete().

Result:

Correctly forwarding of event.
normanmaurer added a commit that referenced this issue Jul 8, 2015
@normanmaurer
[#3945] Http2ConnectionHandler breaks channelReadComplete pipeline no…
e43fede 
…tification

Motivation:

Http2ConnectionHandler missed to forward channelReadComplete(...) events.

Modifications:

Ensure we notify the next handler in the pipeline via ctx.fireChannelReadComplete().

Result:

Correctly forwarding of event.
normanmaurer added a commit that referenced this issue Jul 8, 2015
@normanmaurer
[#3945] Http2ConnectionHandler breaks channelReadComplete pipeline no…
61b9da4 
…tification

Motivation:

Http2ConnectionHandler missed to forward channelReadComplete(...) events.

Modifications:

Ensure we notify the next handler in the pipeline via ctx.fireChannelReadComplete().

Result:

Correctly forwarding of event.
@normanmaurer
Copy link
Member

Fixed by #3948

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@normanmaurer normanmaurer

Labels
defect
Projects
None yet
Milestone
4.1.0.Beta6
Development

No branches or pull requests
3 participants
@normanmaurer @blucas @nmittler