Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.5.4.Final] Default max age set by CookieDecoder is -1, but should be Integer.MIN_VALUE #534

Closed
ngocdaothanh opened this issue Aug 19, 2012 · 7 comments

Comments

@ngocdaothanh
Copy link
Contributor

commented Aug 19, 2012

  1. Write to browser: HTTP server responds a DefaultCookie to browser. The max age will be set to Integer.MIN_VALUE by default.
  2. Read back from browser: On the next request, the browser will send back the cookie. But this time CookieDecoder will decode the max age to -1
@normanmaurer

This comment has been minimized.

Copy link
Member

commented Aug 19, 2012

Would you mind submit a pull request ? I will then pull in and try todo a quick release again to fix the regression

Sent from my iPhone. Excuse any typos....

Am 19.08.2012 um 09:16 schrieb Ngoc Dao notifications@github.com:

Write to browser: HTTP server responds a DefaultCookie to browser. The max age will be set to Integer.MIN_VALUE by default.
Read back from browser: On the next request, the browser will send back the cookie. But this time CookieDecoder will decode the max age to -1

Reply to this email directly or view it on GitHub.

@normanmaurer

This comment has been minimized.

Copy link
Member

commented Aug 19, 2012

@ngocdaothanh could you please verify my last two commits and check if that fix the problem ?

@ghost ghost assigned normanmaurer Aug 19, 2012

@ngocdaothanh

This comment has been minimized.

Copy link
Contributor Author

commented Aug 19, 2012

Thanks a lot.
Your commits fixed the problem.

CruzBishop added a commit to CruzBishop/netty that referenced this issue Aug 20, 2012
Fix issues with Cookie max age test
These issues were introduced while fixing netty#534

Signed-off-by: Cruz Julian Bishop <cruzjbishop@gmail.com>
@ngocdaothanh

This comment has been minimized.

Copy link
Contributor Author

commented Aug 22, 2012

try todo a quick release again to fix the regression

Will you release a quick release soon (just for this problem)?

@normanmaurer

This comment has been minimized.

Copy link
Member

commented Aug 22, 2012

yes.. If everything works out today :)

@ngocdaothanh

This comment has been minimized.

Copy link
Contributor Author

commented Aug 22, 2012

Thanks a lot

@jroper

This comment has been minimized.

Copy link
Contributor

commented Nov 7, 2012

Related, the code still sets dates in the past to be 0: #712

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.