StompSubframeDecoder.redHeaders no any notification when parsed line that contains multiple colon #7083
Assignees
Milestone
Comments
|
@amizurov maybe you want to submit a PR and just make it configurable via a constructor argument (and using the current behaviour by default) ? |
|
@normanmaurer Ok, with great pleasure. |
amizurov
pushed a commit
to amizurov/netty
that referenced
this issue
Aug 28, 2017
…ine that contains multiple colon, close netty#7083
normanmaurer
pushed a commit
that referenced
this issue
Aug 29, 2017
…n parsed line that contains multiple colon Motivation: By STOMP 1.2 specification - header name or value include any octet except CR or LF or ":". Modification: Add constructor argument that allows to enable / disable validation. Result: Fixes [#7083]
|
Fixed by #7160 |
liuzhengyang
pushed a commit
to liuzhengyang/netty
that referenced
this issue
Sep 10, 2017
…n parsed line that contains multiple colon Motivation: By STOMP 1.2 specification - header name or value include any octet except CR or LF or ":". Modification: Add constructor argument that allows to enable / disable validation. Result: Fixes [netty#7083]
kiril-me
pushed a commit
to kiril-me/netty
that referenced
this issue
Feb 28, 2018
…n parsed line that contains multiple colon Motivation: By STOMP 1.2 specification - header name or value include any octet except CR or LF or ":". Modification: Add constructor argument that allows to enable / disable validation. Result: Fixes [netty#7083]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected behavior
By STOMP 1.2 specification - header name or value include any octet except CR or LF or ":".
I understand that we can not just change the current behavior because of compatibility, but maybe we can add some kind of error notification ?
Actual behavior
We can built stomp frame that contain invalid header. And also when decoder parsed line it simply skips it without any notification error.
Steps to reproduce
Build DefaultStompFrame for any command with invalid header (time:2017-01-01T00:00:00) and then decoded message, header missing.
Minimal yet complete reproducer code (or URL to code)
Netty version
4.1.13
JVM version (e.g.
java -version)1.8.0_131
OS version (e.g.
uname -a)ProductName: Mac OS X
ProductVersion: 10.12.6
The text was updated successfully, but these errors were encountered: