Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Encoder and Decoder abstract methods should be protected #846

Closed
normanmaurer opened this Issue · 5 comments

2 participants

@normanmaurer
Collaborator

Currently the abstract methods like encode and decode are public in the Encoder and Decoder classes like ByteToByteDecoder, ByteToByteEncoder etc. I see no reason why they should be public. Maybe protected would be better to tighten up visiblity.

@trustin wdyt ?

@normanmaurer
Collaborator
@trustin
Owner

+1

@normanmaurer
Collaborator
@normanmaurer normanmaurer was assigned
@normanmaurer
Collaborator

done

@ghost Unknown referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
@bk1te bk1te referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.