We should fail fast when a CNAME loop is detected #10305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Once a CNAME loop was detected we can just fail fast and so reduce the number of queries. Modifications: Fail fast once a CNAME loop is detected Result: Fail fast
|
/cc @Bennett-Lynch |
|
@netty-bot test this please |
Bennett-Lynch
approved these changes
May 19, 2020
normanmaurer
added a commit
that referenced
this pull request
May 20, 2020
Motivation: Once a CNAME loop was detected we can just fail fast and so reduce the number of queries. Modifications: Fail fast once a CNAME loop is detected Result: Fail fast
Kvicii
pushed a commit
to Kvicii/netty
that referenced
this pull request
May 21, 2020
* '4.1' of github.com:netty/netty: We should fail fast when a CNAME loop is detected (netty#10305) Dequeue all cached messages and destroy the queue instance after removing the FlowControlHandler from channel pipeline. (netty#10304)
ihanyong
pushed a commit
to ihanyong/netty
that referenced
this pull request
Jul 31, 2020
Motivation: Once a CNAME loop was detected we can just fail fast and so reduce the number of queries. Modifications: Fail fast once a CNAME loop is detected Result: Fail fast
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Once a CNAME loop was detected we can just fail fast and so reduce the number of queries.
Modifications:
Fail fast once a CNAME loop is detected
Result:
Fail fast