Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Not throw an exception if subprotocol is not supported but just drop the... #2149
The problem is that at the moment we throw an WebSocketHandshakeException on the server-side. The proper way would be to just not send back the sub-protocol header like stated in the RFC. This way the client can handle it in a proper way.
I see. Instead we should not modify the pipeline, but just close the connection after sending the response then. Because the client MUST fail the connection, there's no point of keeping the connection in my opinion. Also does our client handle this situation? Can you please add a test case?
sorry I misread this:
If the server's response does not conform to the requirements for the
But why does the RFC not mention the case where the server has no accepted subprotocols? What would be the most sensible behavior that does not violate the RFC?
@trustin Why the client MUST fail the connection ? I was not able to spot this in the RFC. Can you point me to it ?
Reply to this email directly or view it on GitHub: