New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#4170] Shutdown socket before close fd when using epoll transport #4256

Closed
wants to merge 1 commit into
base: 4.0
from

Conversation

Projects
None yet
4 participants
@normanmaurer
Member

normanmaurer commented Sep 23, 2015

Motivation:

We should call shutdown(...) on the socket before closing the filedescriptor to ensure it is closed gracefully.

Modifications:

Call shutdown(...) before close.

Result:

Sockets are gracefully shutdown when using native transport.

@normanmaurer normanmaurer self-assigned this Sep 23, 2015

@normanmaurer normanmaurer added this to the 4.0.32.Final milestone Sep 23, 2015

@normanmaurer normanmaurer added the defect label Sep 23, 2015

[#4170] Shutdown socket before close fd when using epoll transport
Motivation:

We should call shutdown(...) on the socket before closing the filedescriptor to ensure it is closed gracefully.

Modifications:

Call shutdown(...) before close.

Result:

Sockets are gracefully shutdown when using native transport.
@ninja-

This comment has been minimized.

Show comment
Hide comment
@ninja-

ninja- Sep 23, 2015

@normanmaurer Have you seen the failed tests?

ninja- commented Sep 23, 2015

@normanmaurer Have you seen the failed tests?

@normanmaurer

This comment has been minimized.

Show comment
Hide comment
@normanmaurer

normanmaurer Sep 23, 2015

Member

@ninja- yes... pushed an updated commit for which the test suite is currently running

Member

normanmaurer commented Sep 23, 2015

@ninja- yes... pushed an updated commit for which the test suite is currently running

@netkins

This comment has been minimized.

Show comment
Hide comment
@netkins

netkins Sep 23, 2015

TeamCity pull requests :: netty Build 255 is now running

netkins commented on 6e4ec33 Sep 23, 2015

TeamCity pull requests :: netty Build 255 is now running

This comment has been minimized.

Show comment
Hide comment
@netkins

netkins Sep 23, 2015

TeamCity pull requests :: netty Build 255 outcome was SUCCESS
Summary: Tests passed: 4765, ignored: 21 Build time: 00:28:57

netkins replied Sep 23, 2015

TeamCity pull requests :: netty Build 255 outcome was SUCCESS
Summary: Tests passed: 4765, ignored: 21 Build time: 00:28:57

@normanmaurer

This comment has been minimized.

Show comment
Hide comment
@normanmaurer

normanmaurer Sep 23, 2015

Member

@ninja- ok now the fix is correct... please check

Member

normanmaurer commented Sep 23, 2015

@ninja- ok now the fix is correct... please check

@ninja-

This comment has been minimized.

Show comment
Hide comment
@ninja-

ninja- Sep 23, 2015

@normanmaurer easy to test, at the moment backend servers are spamming connection reset and I expect that to go away. I'll let you know

ninja- commented Sep 23, 2015

@normanmaurer easy to test, at the moment backend servers are spamming connection reset and I expect that to go away. I'll let you know

@Scottmitch

This comment has been minimized.

Show comment
Hide comment
@Scottmitch

Scottmitch Sep 25, 2015

Member

@ninja- - Any updates?

Member

Scottmitch commented Sep 25, 2015

@ninja- - Any updates?

@normanmaurer

This comment has been minimized.

Show comment
Hide comment
@normanmaurer

normanmaurer Sep 25, 2015

Member

Cherry-picked into 4.0 (3e4cc9d) , 4.1 (7475334) and master (50086ca)

Member

normanmaurer commented Sep 25, 2015

Cherry-picked into 4.0 (3e4cc9d) , 4.1 (7475334) and master (50086ca)

@normanmaurer normanmaurer deleted the shutdown branch Sep 25, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment