New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#4235] Ensure OpenSslEngine.unwrap(...) / wrap(...) correctly return… #4263

Closed
wants to merge 1 commit into
base: 4.0
from

Conversation

Projects
None yet
3 participants
@normanmaurer
Member

normanmaurer commented Sep 23, 2015

… HandshakeStatus.FINISHED

Motivation:

OpenSslEngine.unwrap(...) / wrap(...) must return HandhsakeStatus.FINISHED if an unwrap or wrap finishes a handshake to behave like descripted in the SSLEngine docs.

Modifications:

  • Ensure we return HandshakeStatus.FINISHED

Result:

Behave correctly.

@ijuma

This comment has been minimized.

Show comment
Hide comment
@ijuma

ijuma Sep 24, 2015

This works fine with the change in #4269 . Thanks!

ijuma commented Sep 24, 2015

This works fine with the change in #4269 . Thanks!

[#4235] Ensure OpenSslEngine.unwrap(...) / wrap(...) correctly return…
… HandshakeStatus.FINISHED

Motivation:

OpenSslEngine.unwrap(...) / wrap(...) must return HandhsakeStatus.FINISHED if an unwrap or wrap finishes a handshake to behave like descripted in the SSLEngine docs.

Modifications:

- Ensure we return HandshakeStatus.FINISHED

Result:

Behave correctly.
@normanmaurer

This comment has been minimized.

Show comment
Hide comment
@normanmaurer

normanmaurer Sep 24, 2015

Member

Cherry-picked into 4.0 (83c2d7c), 4.1 (6c6c369) and master (fc6a9e0)

Member

normanmaurer commented Sep 24, 2015

Cherry-picked into 4.0 (83c2d7c), 4.1 (6c6c369) and master (fc6a9e0)

@normanmaurer normanmaurer deleted the openssl_handshakestatus branch Sep 24, 2015

@normanmaurer

This comment has been minimized.

Show comment
Hide comment
@normanmaurer

normanmaurer Sep 24, 2015

Member

@ijuma thanks again!

Member

normanmaurer commented Sep 24, 2015

@ijuma thanks again!

@normanmaurer normanmaurer added this to the 4.0.32.Final milestone Sep 24, 2015

@normanmaurer normanmaurer self-assigned this Sep 24, 2015

@normanmaurer normanmaurer added the defect label Sep 24, 2015

@netkins

This comment has been minimized.

Show comment
Hide comment
@netkins

netkins Sep 24, 2015

TeamCity pull requests :: netty Build 275 is now running

netkins commented on 3dcf4e2 Sep 24, 2015

TeamCity pull requests :: netty Build 275 is now running

This comment has been minimized.

Show comment
Hide comment
@netkins

netkins Sep 24, 2015

TeamCity pull requests :: netty Build 275 outcome was SUCCESS
Summary: Tests passed: 4765, ignored: 21 Build time: 00:30:05

netkins replied Sep 24, 2015

TeamCity pull requests :: netty Build 275 outcome was SUCCESS
Summary: Tests passed: 4765, ignored: 21 Build time: 00:30:05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment