New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3789] Correctly reset markers for all allocations when using Pooled… #4278

Closed
wants to merge 1 commit into
base: 4.0
from

Conversation

Projects
None yet
5 participants
@normanmaurer
Member

normanmaurer commented Sep 25, 2015

…ByteBufAllocator

Motivation:

We need to ensure all markers are reset when doing an allocation via the PooledByteBufAllocator. This was not the always the case.

Modifications:

Move all logic that needs to get executed when reuse a PooledByteBuf into one place and call it.

Result:

Correct behavior

[#3789] Correctly reset markers for all allocations when using Pooled…
…ByteBufAllocator

Motivation:

We need to ensure all markers are reset when doing an allocation via the PooledByteBufAllocator. This was not the always the case.

Modifications:

Move all logic that needs to get executed when reuse a PooledByteBuf into one place and call it.

Result:

Correct behavior

@normanmaurer normanmaurer self-assigned this Sep 25, 2015

@normanmaurer normanmaurer added this to the 4.0.32.Final milestone Sep 25, 2015

@netkins

This comment has been minimized.

Show comment
Hide comment
@netkins

netkins Sep 25, 2015

TeamCity pull requests :: netty Build 281 is now running

netkins commented on d256e0d Sep 25, 2015

TeamCity pull requests :: netty Build 281 is now running

This comment has been minimized.

Show comment
Hide comment
@netkins

netkins Sep 25, 2015

TeamCity pull requests :: netty Build 281 outcome was SUCCESS
Summary: Tests passed: 4769, ignored: 21 Build time: 00:30:16

netkins replied Sep 25, 2015

TeamCity pull requests :: netty Build 281 outcome was SUCCESS
Summary: Tests passed: 4769, ignored: 21 Build time: 00:30:16

This comment has been minimized.

Show comment
Hide comment
@ninja-

ninja- Sep 25, 2015

I think that after messing a lot with my buffers, I introduced a very rare stream corruption and I thought about blaming these indexes(more optimized = less buffers in rotation = more likely to trigger such a thing by reusing a buf)...so it's interesting for me to see such a change and pull it.

ninja- replied Sep 25, 2015

I think that after messing a lot with my buffers, I introduced a very rare stream corruption and I thought about blaming these indexes(more optimized = less buffers in rotation = more likely to trigger such a thing by reusing a buf)...so it's interesting for me to see such a change and pull it.

@normanmaurer normanmaurer added the defect label Sep 25, 2015

@jesperpedersen

This comment has been minimized.

Show comment
Hide comment
@jesperpedersen

jesperpedersen commented Sep 25, 2015

+1

@Scottmitch

This comment has been minimized.

Show comment
Hide comment
@Scottmitch

Scottmitch Sep 25, 2015

Member

lgtm

Member

Scottmitch commented Sep 25, 2015

lgtm

@netkins

This comment has been minimized.

Show comment
Hide comment
@netkins

netkins Sep 25, 2015

TeamCity pull requests :: netty Build 281 is now running

netkins commented on d256e0d Sep 25, 2015

TeamCity pull requests :: netty Build 281 is now running

This comment has been minimized.

Show comment
Hide comment
@netkins

netkins Sep 25, 2015

TeamCity pull requests :: netty Build 281 outcome was SUCCESS
Summary: Tests passed: 4769, ignored: 21 Build time: 00:30:16

netkins replied Sep 25, 2015

TeamCity pull requests :: netty Build 281 outcome was SUCCESS
Summary: Tests passed: 4769, ignored: 21 Build time: 00:30:16

This comment has been minimized.

Show comment
Hide comment
@ninja-

ninja- Sep 25, 2015

I think that after messing a lot with my buffers, I introduced a very rare stream corruption and I thought about blaming these indexes(more optimized = less buffers in rotation = more likely to trigger such a thing by reusing a buf)...so it's interesting for me to see such a change and pull it.

ninja- replied Sep 25, 2015

I think that after messing a lot with my buffers, I introduced a very rare stream corruption and I thought about blaming these indexes(more optimized = less buffers in rotation = more likely to trigger such a thing by reusing a buf)...so it's interesting for me to see such a change and pull it.

@normanmaurer

This comment has been minimized.

Show comment
Hide comment
@normanmaurer

normanmaurer Sep 25, 2015

Member

Cherry-picked into 4.0 (3de8768) , 4.1 (956a757) and master (f746f0c)

Member

normanmaurer commented Sep 25, 2015

Cherry-picked into 4.0 (3de8768) , 4.1 (956a757) and master (f746f0c)

@normanmaurer normanmaurer deleted the reset_marks branch Sep 25, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment