Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the incorrect usage/value of 'Connection: upgrade' #4525

Closed
wants to merge 1 commit into from

Conversation

@trustin
Copy link
Member

commented Nov 29, 2015

Motivation:

HttpClientUpgradeHandler uses HttpHeaderNames.UPGRADE as the value of
the 'Connection' header, which is incorrect. It should use
HttpHeaderValues.UPGRADE instead (note Names vs Values.)

Also, HttpHeaderValues.UPGRADE should be 'upgrade' rather than
'Upgrade', as defined in:

Modifications:

  • Use HttpHeaderValues.UPGRADE for a 'Connection' header
  • Lowercase the value of HttpHeaderValues.UPGRADE

Result:

  • Fixes #4508
  • Correct behavior
Fix the incorrect usage/value of 'Connection: upgrade'
Motivation:

HttpClientUpgradeHandler uses HttpHeaderNames.UPGRADE as the value of
the 'Connection' header, which is incorrect. It should use
HttpHeaderValues.UPGRADE instead (note Names vs Values.)

Also, HttpHeaderValues.UPGRADE should be 'upgrade' rather than
'Upgrade', as defined in:

- https://tools.ietf.org/html/rfc7230#section-6.7

Modifications:

- Use HttpHeaderValues.UPGRADE for a 'Connection' header
- Lowercase the value of HttpHeaderValues.UPGRADE

Result:

- Fixes #4508
- Correct behavior

@trustin trustin added the defect label Nov 29, 2015

@trustin trustin added this to the 4.1.0.CR1 milestone Nov 29, 2015

@trustin

This comment has been minimized.

Copy link
Member Author

commented Nov 29, 2015

@normanmaurer

This comment has been minimized.

Copy link
Member

commented Nov 29, 2015

LGTM

@netkins

This comment has been minimized.

Copy link

commented on 62aa077 Nov 29, 2015

TeamCity pull requests :: netty Build 786 is now running

This comment has been minimized.

Copy link

replied Nov 29, 2015

TeamCity pull requests :: netty Build 786 outcome was SUCCESS
Summary: Tests passed: 6215, ignored: 21 Build time: 01:29:08

@normanmaurer

This comment has been minimized.

Copy link
Member

commented Nov 29, 2015

Cherry-picked into 4.1 (c1f3200) and master (d68219c)

@normanmaurer normanmaurer deleted the wrong_upgrade branch Nov 29, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.