Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp InboundHttp2ToHttpAdapter builder API #4582

Closed
wants to merge 1 commit into from

Conversation

@trustin
Copy link
Member

commented Dec 17, 2015

Related: #4572 #4574

Motivation:

Consistency in our builder API design

Modifications:

  • Add AbstractInboundHttp2ToHttpAdapterBuilder
  • Replace the old 'Builder's with InboundHttp2ToHttpAdapterBuilder and
    InboundHttp2ToHttpPriorityAdapterBuilder

Result:

Builder API consistency

@trustin trustin added the feature label Dec 17, 2015

@trustin trustin added this to the 4.1.0.CR1 milestone Dec 17, 2015

@trustin

This comment has been minimized.

Copy link
Member Author

commented Dec 17, 2015

@trustin trustin force-pushed the builder_api_3 branch 2 times, most recently from 9abde14 to 69d341b Dec 17, 2015

Revamp InboundHttp2ToHttpAdapter builder API
Related: #4572 #4574

Motivation:

Consistency in our builder API design

Modifications:

- Add AbstractInboundHttp2ToHttpAdapterBuilder
- Replace the old 'Builder's with InboundHttp2ToHttpAdapterBuilder and
  InboundHttp2ToHttpPriorityAdapterBuilder

Result:

Builder API consistency
@netkins

This comment has been minimized.

Copy link

commented on 69d341b Dec 17, 2015

TeamCity pull requests :: netty Build 902 is now running

This comment has been minimized.

Copy link

replied Dec 17, 2015

TeamCity pull requests :: netty Build 902 outcome was SUCCESS
Summary: Tests passed: 6228, ignored: 21 Build time: 00:43:09

* for the current connection
*/
protected AbstractInboundHttp2ToHttpAdapterBuilder(Http2Connection connection) {
this.connection = connection;

This comment has been minimized.

Copy link
@normanmaurer

normanmaurer Dec 17, 2015

Member

check for null as this should never be null.

@normanmaurer

This comment has been minimized.

Copy link
Member

commented Dec 17, 2015

@trustin just one comment

@Scottmitch

This comment has been minimized.

Copy link
Member

commented Dec 17, 2015

lgtm

@trustin

This comment has been minimized.

Copy link
Member Author

commented Dec 18, 2015

Cherry-picked after addressing the comment: b39380a (4.1)

@trustin trustin closed this Dec 18, 2015

@trustin trustin deleted the builder_api_3 branch Dec 18, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.