[#5773] AbstractByteBuf.forEachByteDesc(ByteProcessor) starts from wr… #5783

Closed
wants to merge 1 commit into
from

Projects

None yet

4 participants

@normanmaurer
Member

…ong index

Motivation:

We introduced a regression in 1abdbe6 which let the iteration start from the wrong index.

Modifications:

Fix start index and add tests.

Result:

Fix regression.

@normanmaurer normanmaurer [#5773] AbstractByteBuf.forEachByteDesc(ByteProcessor) starts from wr…
…ong index

Motivation:

We introduced a regression in 1abdbe6 which let the iteration start from the wrong index.

Modifications:

Fix start index and add tests.

Result:

Fix regression.
7ea5d04
@johnou

Based off the previous diff shouldn't this read

return forEachByteDesc0(readerIndex, writerIndex -  readerIndex, processor);
Member
@normanmaurer normanmaurer added the defect label Aug 31, 2016
@normanmaurer normanmaurer added this to the 4.0.42.Final milestone Aug 31, 2016
@normanmaurer normanmaurer self-assigned this Aug 31, 2016
@normanmaurer
Member

@Scottmitch PTAL.. also @npordash

@npordash

My unit tests are now passing 👍

@normanmaurer
Member

@Scottmitch reviewed offline...

@normanmaurer
Member

Cherry-picked into 4.1 (463b5cf) and 4.0 (f66f4c9)

@normanmaurer normanmaurer deleted the for_each_byte_desc_regression branch Sep 1, 2016
@Scottmitch
Member

lgtm ... thanks @normanmaurer !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment