[#5760] Do not change writerIndex when decode DnsPtrRecord #5784

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@normanmaurer
Member

Motivation:

We need to not change the original writerIndex when decode a DnsPtrRecord as otherwise we will not be able to decode other records that follow it.

Modifications:

Slice the data out and so not increase the writerIndex.

Result:

No more problems when decoding.

@normanmaurer normanmaurer [#5760] Do not change writerIndex when decode DnsPtrRecord
Motivation:

We need to not change the original writerIndex when decode a DnsPtrRecord as otherwise we will not be able to decode other records that follow it.

Modifications:

Slice the data out and so not increase the writerIndex.

Result:

No more problems when decoding.
2d89387
@normanmaurer normanmaurer added the defect label Aug 31, 2016
@normanmaurer normanmaurer added this to the 4.1.6.Final milestone Aug 31, 2016
@normanmaurer normanmaurer self-assigned this Aug 31, 2016
@Scottmitch
Member

lgtm

@normanmaurer
Member

Cherry-picked into 4.1 (8cf90f0)

@normanmaurer normanmaurer deleted the dns_bug branch Sep 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment