Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unbalanced quotes in Bundle-NativeCode manifest header #5949

Closed
wants to merge 1 commit into from

Conversation

@chringwer
Copy link

commented Oct 27, 2016

Motivation:
The previously generated manifest causes a parse exception when loaded into an Apache Felix OSGI container.

Modifications:
Fix parameter delimiter and unbalanced quotes in manifest entry. Suffixed with asterisk so the bundle is resolved on other architectures as well even if native libs won't be loaded.

Result:
Bundle will load properly in OSGI containers.

@chringwer

This comment has been minimized.

Copy link
Author

commented Oct 27, 2016

Here is the stacktrace that is caused by the current manifest header when loaded into karaf:

org.osgi.framework.BundleException: Could not create bundle object.
    at org.apache.felix.framework.Felix.installBundle(Felix.java:3057)
    at org.apache.felix.framework.BundleContextImpl.installBundle(BundleContextImpl.java:167)
    at org.eclipse.equinox.internal.region.BundleIdBasedRegion.installBundle0(BundleIdBasedRegion.java:117)
    at org.eclipse.equinox.internal.region.BundleIdBasedRegion.installBundleAtLocation(BundleIdBasedRegion.java:97)
    at org.apache.karaf.features.internal.service.FeaturesServiceImpl.installBundle(FeaturesServiceImpl.java:1237)
    at org.apache.karaf.features.internal.service.Deployer.deploy(Deployer.java:724)
    at org.apache.karaf.features.internal.service.FeaturesServiceImpl.doProvision(FeaturesServiceImpl.java:1152)
    at org.apache.karaf.features.internal.service.FeaturesServiceImpl$1.call(FeaturesServiceImpl.java:1048)
    at java.util.concurrent.FutureTask.run(FutureTask.java:266)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
    at java.lang.Thread.run(Thread.java:745)
Caused by: java.lang.NullPointerException
    at org.apache.felix.framework.util.manifestparser.ManifestParser.<init>(ManifestParser.java:261)
    at org.apache.felix.framework.BundleRevisionImpl.<init>(BundleRevisionImpl.java:121)
    at org.apache.felix.framework.BundleImpl.createRevision(BundleImpl.java:1282)
    at org.apache.felix.framework.BundleImpl.<init>(BundleImpl.java:113)
    at org.apache.felix.framework.Felix.installBundle(Felix.java:3004)
    ... 11 more
Christoph Ingwersen
Fix unbalanced quotes in Bundle-NativeCode manifest header
Motivation:

The previously generated manifest causes a parse exception when loaded into an Apache Felix OSGI container.

Modifications:

Fix parameter delimiter and unbalanced quotes in manifest entry. Suffixed with asterisk so the bundle is resolved on other architectures as well even if native libs won't be loaded.

Result:

Bundle will load properly in OSGI containers.

@chringwer chringwer force-pushed the chringwer:fix-epoll-manifest branch from ba40d57 to 969ac28 Oct 27, 2016

@normanmaurer

This comment has been minimized.

Copy link
Member

commented Oct 30, 2016

@chringwer can you please sign our ICLA and ping me once done ?

http://netty.io/s/icla

@normanmaurer normanmaurer self-assigned this Oct 30, 2016

@normanmaurer normanmaurer added the defect label Oct 30, 2016

@normanmaurer normanmaurer added this to the 4.0.43.Final milestone Oct 30, 2016

@normanmaurer

This comment has been minimized.

Copy link
Member

commented Nov 1, 2016

Cherry-picked into 4.1 (b6099bc) and 4.0 (a5feee5)

@chringwer thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.