New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SslCloseCompletionEvent that is fired once a close_notify was rec… #6242

Closed
wants to merge 1 commit into
base: 4.1
from

Conversation

Projects
None yet
3 participants
@normanmaurer
Member

normanmaurer commented Jan 18, 2017

…eived

Motivation:

For the completion of a handshake we already fire a SslHandshakeCompletionEvent which the user can intercept. We should do the same for the receiving of close_notify.

Modifications:

Add SslCloseCompletionEvent and test-case.

Result:

More consistent API.

@normanmaurer normanmaurer added this to the 4.0.44.Final milestone Jan 18, 2017

@normanmaurer normanmaurer self-assigned this Jan 18, 2017

@normanmaurer normanmaurer requested review from trustin, nmittler and Scottmitch Jan 18, 2017

Add SslCloseCompletionEvent that is fired once a close_notify was rec…
…eived

Motivation:

For the completion of a handshake we already fire a SslHandshakeCompletionEvent which the user can intercept. We should do the same for the receiving of close_notify.

Modifications:

Add SslCloseCompletionEvent and test-case.

Result:

More consistent API.
@nmittler

Good idea!

@normanmaurer

This comment has been minimized.

Show comment
Hide comment
@normanmaurer

normanmaurer Jan 19, 2017

Member

Cherry-picked into 4.1 (d55c321) and 4.0 (0ccab2b)

Member

normanmaurer commented Jan 19, 2017

Cherry-picked into 4.1 (d55c321) and 4.0 (0ccab2b)

@normanmaurer normanmaurer deleted the ssl_events branch Jan 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment