Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
DnsNameResolver.resolve*(...) never notifies the Future when empty ho… #6258
…stname is used.
When an empty hostname is used in DnsNameResolver.resolve*(...) it will never notify the future / promise. The root cause is that we not correctly guard against errors of IDN.toASCII(...) which will throw an IllegalArgumentException when it can not parse its input. That said we should also handle an empty hostname the same way as the JDK does and just use "localhost" when this happens.
DnsNameResolver.resolve*(...) will always notify the future.
referenced this pull request
Jan 20, 2017
just some test updates ... approach looks good.