Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Ensure calling ReferenceCountedOpenSslEngine.wrap(...) after closeOut… #6262
…bound() was called will not throw an SSLException
PR [#6238] added guards to be able to call wrap(...) / unwrap(...) after the engine was shutdown. Unfortunally one case was missed which is when closeOutbound() was called and produced some data while closeInbound() was not called yet.
Correctly guard against SSLException when closeOutbound() was called, produced data and someone calls wrap(...) after it.
No more SSLException. Fixes [#6260].
referenced this pull request
Jan 20, 2017
Yea, a couple of times per minute (before the first fix it was every other second). All I needed to do is to deploy one server with the new artifact and watch the logs. It's something we can thankfully do very quickly (and Netty is thanks to the Unit Tests quite low risk).