New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly detect which protocols are supported when using OpenSSL #6290

Closed
wants to merge 1 commit into
base: 4.1
from

Conversation

Projects
None yet
2 participants
@normanmaurer
Member

normanmaurer commented Jan 27, 2017

Motivation:

We failed to properly test if a protocol is supported on an OpenSSL installation and just always returned all protocols.

Modifications:

  • Detect which protocols are supported on a platform.
  • Skip protocols in tests when not supported. This fixes a build error on some platforms introduced by [#6276].

Result:

Correctly return only the supported protocols

@normanmaurer normanmaurer requested a review from Scottmitch Jan 27, 2017

Correctly detect which protocols are supported when using OpenSSL
Motivation:

We failed to properly test if a protocol is supported on an OpenSSL installation and just always returned all protocols.

Modifications:

- Detect which protocols are supported on a platform.
- Skip protocols in tests when not supported. This fixes a build error on some platforms introduced by [#6276].

Result:

Correctly return only the supported protocols

@normanmaurer normanmaurer added this to the 4.0.44.Final milestone Jan 27, 2017

@normanmaurer

This comment has been minimized.

Show comment
Hide comment
@normanmaurer

normanmaurer Jan 27, 2017

Member

cherry-picked into 4.1 (7a39afd) and 4.0 (bb14407)

Member

normanmaurer commented Jan 27, 2017

cherry-picked into 4.1 (7a39afd) and 4.0 (bb14407)

@normanmaurer normanmaurer deleted the openssl_supported_protocols branch Jan 27, 2017

@normanmaurer normanmaurer self-assigned this Jan 27, 2017

@normanmaurer normanmaurer added the defect label Jan 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment