New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore add(Promise) and addAll(Promise...) methods to PromiseCombiner (fixes #6283) #6292

Closed
wants to merge 1 commit into
base: 4.1
from

Conversation

Projects
None yet
2 participants
@jchambers
Contributor

jchambers commented Jan 29, 2017

Motivation

A testing goof in 7c630fe introduced a binary incompatibility when the old Promise-specific add and addAll methods in PromiseCombiner were generalized to accept Futures.

Modification

  • Restore (but mark as @Deprecated) old PromiseCombiner methods.
  • Fixed a couple minor documentation typos because sure why not.

Result

Fixes #6283; PromiseCombiner is binary-compatible with previous versions of Netty.


Sorry for the trouble here! @normanmaurer totally called this one, but I managed to convince myself through (incorrect) testing that it wasn't an issue.

Restore add(Promise) and addAll(Promise...) methods to PromiseCombiner.
Motivation:

A testing goof in 7c630fe introduced a binary incompatibility when the old Promise-specific `add` and `addAll` methods in PromiseCombiner were generalized to accept `Futures`.

Modification:

- Restore (but mark as `@deprecated`) old PromiseCombiner methods.
- Fixed a couple minor documentation typos because sure why not.

Result:

`PromiseCombiner` is binary-compatible with previous versions of Netty.
@normanmaurer

This comment has been minimized.

Show comment
Hide comment
@normanmaurer

normanmaurer Jan 30, 2017

Member

Cherry-picked into 4.1 (94cb389)

@jchambers thanks a lot!

Member

normanmaurer commented Jan 30, 2017

Cherry-picked into 4.1 (94cb389)

@jchambers thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment