New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record release when enable detailed leak detection #6972

Closed
wants to merge 1 commit into
base: 4.1
from

Conversation

Projects
None yet
3 participants
@louxiu
Contributor

louxiu commented Jul 16, 2017

Motivation:
It would be easier to find where is missing release call in several retain release calls on a ByteBuf

Modifications:
Remove final modifier on SimpleLeakAwareByteBuf release function and override it to record release in AdvancedLeakAwareByteBuf and AdvancedLeakAwareCompositeByteBuf

Result:
Release will be recorded when enable detailed leak detection

Record release when enable detailed leak detection
Motivation:
It would be easier to find where is missing release call in several retain release calls on a ByteBuf

Modifications:
Remove final modifier on SimpleLeakAwareByteBuf and SimpleLeakAwareByteBuf release function and override it to record release in AdvancedLeakAwareByteBuf and AdvancedLeakAwareCompositeByteBuf

Result:
Release will be recorded when enable detailed leak detection
@normanmaurer

This comment has been minimized.

Show comment
Hide comment
@normanmaurer

normanmaurer Jul 16, 2017

Member

@trustin @Scottmitch WDYT... I think this is not a bad idea...

Member

normanmaurer commented Jul 16, 2017

@trustin @Scottmitch WDYT... I think this is not a bad idea...

@normanmaurer normanmaurer added this to the 4.0.50.Final milestone Jul 16, 2017

@normanmaurer normanmaurer self-assigned this Jul 16, 2017

@normanmaurer

This comment has been minimized.

Show comment
Hide comment
@normanmaurer

normanmaurer Jul 18, 2017

Member

Cherry-picked into 4.1 (0ad9931) and 4.0 (c4213bc)

Member

normanmaurer commented Jul 18, 2017

Cherry-picked into 4.1 (0ad9931) and 4.0 (c4213bc)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment