New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DefaultSocks5CommandRequest incorrectly rejects SOCKS5 commands with … #7157

Closed
wants to merge 1 commit into
base: 4.1
from

Conversation

Projects
None yet
2 participants
@normanmaurer
Member

normanmaurer commented Aug 28, 2017

…dstPort=0

Motivation:

According to SOCKS 5 spec, dstPort = 0 is a valid value in case of UDP ASSOCIATE.

Modifications:

  • Allow 0 as port.
  • Add unit tests.

Result:

Fixes [#7156].

@lkoszanski

This comment has been minimized.

Show comment
Hide comment
@lkoszanski

lkoszanski Aug 28, 2017

lkoszanski commented Aug 28, 2017

DefaultSocks5CommandRequest incorrectly rejects SOCKS5 commands with …
…dstPort=0

Motivation:

According to SOCKS 5 spec, dstPort = 0 is a valid value in case of UDP ASSOCIATE.

Modifications:

- Allow 0 as port.
- Add unit tests.

Result:

Fixes [#7156].
@normanmaurer

This comment has been minimized.

Show comment
Hide comment
@normanmaurer

normanmaurer Aug 29, 2017

Member

Cherry-picked into 4.1 (f5bea11) as it is a trivial fix.

Member

normanmaurer commented Aug 29, 2017

Cherry-picked into 4.1 (f5bea11) as it is a trivial fix.

@normanmaurer normanmaurer deleted the socks5_port_0 branch Aug 29, 2017

@normanmaurer normanmaurer added this to the 4.1.16.Final milestone Aug 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment