Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Not add inboundStreamHandler for outbound streams created by Http2Mul… #7180
We must not add the inboundStreamHandler for outbound streams creates by Http2MultiplexCodec as the user will specify a handler via Http2StreamChannelBootstrap.
referenced this pull request
Sep 5, 2017
This seems fine for now. I think we'll eventually want to improve
+1... baby steps ;)…
Am 05.09.2017 um 20:58 schrieb Eric Anderson ***@***.***>: This seems fine for now. I think we'll eventually want to improve Http2StreamChannelBootstrap so that the handler is added before the channel is registered (e.g., we could pass handler to newOutboundStream()). But it looks like Http2StreamChannelBootstrap could use other improvements during init(), like how late it sets channel options/attributes. It'll probably need a refactor later. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub, or mute the thread.