New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#7205] Check on wrong CONNECT packet with password but without username #7206

Closed
wants to merge 2 commits into
base: 4.1
from

Conversation

Projects
None yet
2 participants
@ppatierno
Contributor

ppatierno commented Sep 13, 2017

Added checking on password set but username not in the CONNECT encoding method

Changed the way how hasUsername and hasPassword are set in the CONNECT packet
Added unit test with a wrong CONNECT packet having password set but not username

Motivation:

Explain here the context, and why you're making that change.
What is the problem you're trying to solve.

Modification:

Describe the modifications you've done.

Result:

Fixes #.

If there is no issue then describe the changes introduced by this PR.

Added checking on password set but username not in the CONNECT encodi…
…ng method

Changed the way how hasUsername and hasPassword are set in the CONNECT packet
Added unit test with a wrong CONNECT packet having password set but not username
@normanmaurer

This comment has been minimized.

Show comment
Hide comment
Member

normanmaurer commented Sep 13, 2017

@ppatierno

This comment has been minimized.

Show comment
Hide comment
@ppatierno

ppatierno Sep 13, 2017

Contributor

@normanmaurer done !

Contributor

ppatierno commented Sep 13, 2017

@normanmaurer done !

@normanmaurer

This comment has been minimized.

Show comment
Hide comment
@normanmaurer

normanmaurer Sep 14, 2017

Member

Squashes and adjusted commit message and cherry-picked into 4.1 (901c66f).

Member

normanmaurer commented Sep 14, 2017

Squashes and adjusted commit message and cherry-picked into 4.1 (901c66f).

@normanmaurer

This comment has been minimized.

Show comment
Hide comment
@normanmaurer
Member

normanmaurer commented Sep 14, 2017

@ppatierno thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment