New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Conscrypt to 1.0.0.RC11 #7235

Closed
wants to merge 1 commit into
base: 4.1
from

Conversation

Projects
None yet
2 participants
@nmittler
Member

nmittler commented Sep 21, 2017

Motivation:

Getting the latest Conscrypt goodies.

Modifications:

A few API changes have occurred, specifically in the Conscrypt
class.

Result:

Netty now builds and tests against Conscrypt 1.0.0.RC11

@nmittler nmittler requested a review from normanmaurer Sep 21, 2017

@normanmaurer

This comment has been minimized.

Show comment
Hide comment
@normanmaurer

normanmaurer Sep 21, 2017

Member

@nmittler can you please rebase ?

Member

normanmaurer commented Sep 21, 2017

@nmittler can you please rebase ?

@nmittler

This comment has been minimized.

Show comment
Hide comment
@nmittler
Member

nmittler commented Sep 21, 2017

@nmittler

This comment has been minimized.

Show comment
Hide comment
@nmittler

nmittler Sep 25, 2017

Member

@normanmaurer any other comments or shall I commit?

Member

nmittler commented Sep 25, 2017

@normanmaurer any other comments or shall I commit?

@normanmaurer

This comment has been minimized.

Show comment
Hide comment
@normanmaurer
Member

normanmaurer commented Sep 25, 2017

@nmittler go for it

@nmittler

This comment has been minimized.

Show comment
Hide comment
@nmittler

nmittler Sep 25, 2017

Member

@normanmaurer I'm in the process of cutting another release candidate that the Jetty guys need, which has a couple more API changes. I'll just update this PR to use RC11 once it's available on Maven central.

Member

nmittler commented Sep 25, 2017

@normanmaurer I'm in the process of cutting another release candidate that the Jetty guys need, which has a couple more API changes. I'll just update this PR to use RC11 once it's available on Maven central.

@normanmaurer

This comment has been minimized.

Show comment
Hide comment
@normanmaurer

normanmaurer Sep 25, 2017

Member

@nmittler works for me

Member

normanmaurer commented Sep 25, 2017

@nmittler works for me

Upgrade Conscrypt to 1.0.0.RC11
Motivation:

Getting the latest Conscrypt goodies.

Modifications:

A few API changes have occurred, specifically in the Conscrypt
class.

Result:

Netty now builds and tests against Conscrypt 1.0.0.RC11
@nmittler

This comment has been minimized.

Show comment
Hide comment
@nmittler
Member

nmittler commented Sep 25, 2017

@nmittler nmittler changed the title from Upgrade Conscrypt to 1.0.0.RC10 to Upgrade Conscrypt to 1.0.0.RC11 Sep 25, 2017

@normanmaurer

This comment has been minimized.

Show comment
Hide comment
@normanmaurer

normanmaurer Sep 26, 2017

Member

@nmittler ship it to 4.1 and 4.0 please

Member

normanmaurer commented Sep 26, 2017

@nmittler ship it to 4.1 and 4.0 please

@normanmaurer

This comment has been minimized.

Show comment
Hide comment
@normanmaurer

normanmaurer Sep 26, 2017

Member

Cherry-picked into 4.1 (5a6ee27) and 4.0 (1cac3d6)

Member

normanmaurer commented Sep 26, 2017

Cherry-picked into 4.1 (5a6ee27) and 4.0 (1cac3d6)

@normanmaurer normanmaurer self-assigned this Sep 26, 2017

@normanmaurer normanmaurer added this to the 4.0.53.Final milestone Sep 26, 2017

@nmittler

This comment has been minimized.

Show comment
Hide comment
@nmittler
Member

nmittler commented Sep 26, 2017

@normanmaurer thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment