New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DnsResolver CNAME redirect bug #7291

Closed
wants to merge 1 commit into
base: 4.1
from

Conversation

Projects
None yet
2 participants
@Scottmitch
Member

Scottmitch commented Oct 11, 2017

Motviation:
DnsNameResolverContext#followCname attempts to build a query to follow a CNAME, but puts the original hostname in the DnsQuery instead of the CNAME hostname. This will result in not following CNAME redirects correctly.

Result:

  • DnsNameResolverContext#followCname should use the CNAME instead of the original hostname when building the DnsQuery

Result:
More correct handling of redirect queries.

@Scottmitch Scottmitch added the defect label Oct 11, 2017

@Scottmitch Scottmitch added this to the 4.1.17.Final milestone Oct 11, 2017

@Scottmitch Scottmitch self-assigned this Oct 11, 2017

@Scottmitch Scottmitch requested a review from normanmaurer Oct 11, 2017

@Scottmitch Scottmitch changed the title from DnsResovler CNAME redirect bug to DnsResolver CNAME redirect bug Oct 11, 2017

DnsResolver CNAME redirect bug
Motviation:
DnsNameResolverContext#followCname attempts to build a query to follow a CNAME, but puts the original hostname in the DnsQuery instead of the CNAME hostname. This will result in not following CNAME redirects correctly.

Result:
- DnsNameResolverContext#followCname should use the CNAME instead of the original hostname when building the DnsQuery

Result:
More correct handling of redirect queries.
testCNAMERecursiveResolve(false);
}
public void testCNAMERecursiveResolve(boolean ipv4Preferred) throws IOException, InterruptedException {

This comment has been minimized.

@normanmaurer

normanmaurer Oct 21, 2017

Member

nit: make this private

@normanmaurer

normanmaurer Oct 21, 2017

Member

nit: make this private

This comment has been minimized.

@Scottmitch

Scottmitch Oct 23, 2017

Member

done

@Scottmitch

Scottmitch Oct 23, 2017

Member

done

@Scottmitch

This comment has been minimized.

Show comment
Hide comment
@Scottmitch
Member

Scottmitch commented Oct 23, 2017

4.1 (dcb828f)

@Scottmitch Scottmitch closed this Oct 23, 2017

@Scottmitch Scottmitch deleted the Scottmitch:dns_redirect branch Oct 23, 2017

@normanmaurer

This comment has been minimized.

Show comment
Hide comment
@normanmaurer
Member

normanmaurer commented Oct 23, 2017

@Scottmitch thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment