New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenSslX509KeyManagerFactory which makes it even easier for peopl… #8084

Merged
merged 3 commits into from Jul 10, 2018

Conversation

@normanmaurer
Member

normanmaurer commented Jun 29, 2018

…e to get the maximum performance when using OpenSSL / LibreSSL / BoringSSL with netty.

Motivation:

To make it even easier for people to get the maximum performance when using native SSL we should provide our own KeyManagerFactory implementation that people can just use to configure their key material.

Modifications:

  • Add OpenSslX509KeyManagerFactory which users can use for maximum performance with native SSL
  • Refactor some internal code to re-use logic and not duplicate it.

Result:

Easier to get the max performance out of native SSL implementation.

Add OpenSslX509KeyManagerFactory which makes it even easier for peopl…
…e to get the maximum performance when using OpenSSL / LibreSSL / BoringSSL with netty.

Motivation:

To make it even easier for people to get the maximum performance when using native SSL we should provide our own KeyManagerFactory implementation that people can just use to configure their key material.

Modifications:

- Add OpenSslX509KeyManagerFactory which users can use for maximum performance with native SSL
- Refactor some internal code to re-use logic and not duplicate it.

Result:

Easier to get the max performance out of native SSL implementation.
@normanmaurer

This comment has been minimized.

Show comment
Hide comment
@normanmaurer

normanmaurer Jul 2, 2018

Member

@carl-mastrangelo any other comments ? Also @mosesn @bryce-anderson @ejona86 any comments ? I would love to include this as part of the next release

Member

normanmaurer commented Jul 2, 2018

@carl-mastrangelo any other comments ? Also @mosesn @bryce-anderson @ejona86 any comments ? I would love to include this as part of the next release

@bryce-anderson

I'm not familiar with the usage of this code so I can only comment on the structure of of it, and it looks good to me.

@ryanoneill may have some more useful comments.

@normanmaurer normanmaurer merged commit a137291 into 4.1 Jul 10, 2018

1 check passed

continuous-integration/teamcity Finished TeamCity Build pull requests :: netty : Tests passed: 13828, ignored: 126
Details

@normanmaurer normanmaurer deleted the openssl_key_manager_factory branch Jul 10, 2018

@normanmaurer normanmaurer self-assigned this Jul 10, 2018

@normanmaurer normanmaurer added this to the 4.1.26.Final milestone Jul 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment