New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DnsNameResolver hangs if search domain results in invalid hostname #8180

Merged
merged 1 commit into from Aug 8, 2018

Conversation

Projects
None yet
2 participants
@Scottmitch
Member

Scottmitch commented Aug 8, 2018

Motivation:
DnsNameResolver manages search domains and will retry the request with the different search domains provided to it. However if the query results in an invalid hostname, the Future corresponding to the resolve request will never be completed.

Modifications:

  • If a resolve attempt results in an invalid hostname and the query isn't issued we should fail the associated promise

Result:
No more hang from DnsNameResolver if search domain results in invalid hostname.

DnsNameResolver hangs if search domain results in invalid hostname
Motivation:
DnsNameResolver manages search domains and will retry the request with the different search domains provided to it. However if the query results in an invalid hostname, the Future corresponding to the resolve request will never be completed.

Modifications:
- If a resolve attempt results in an invalid hostname and the query isn't issued we should fail the associated promise

Result:
No more hang from DnsNameResolver if search domain results in invalid hostname.

@Scottmitch Scottmitch requested a review from normanmaurer Aug 8, 2018

@normanmaurer

This comment has been minimized.

Show comment
Hide comment
@normanmaurer

normanmaurer Aug 8, 2018

Member

@Scottmitch good catch!

Member

normanmaurer commented Aug 8, 2018

@Scottmitch good catch!

@normanmaurer normanmaurer merged commit b3b04d0 into netty:4.1 Aug 8, 2018

1 check passed

continuous-integration/teamcity Finished TeamCity Build pull requests :: netty : Tests passed: 13852, ignored: 128
Details

@normanmaurer normanmaurer added this to the 4.1.29.Final milestone Aug 8, 2018

@normanmaurer normanmaurer added the defect label Aug 8, 2018

@Scottmitch Scottmitch deleted the Scottmitch:dns_hang branch Aug 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment