New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround JDK bug that will cause an AssertionError when calling Ser… #8183

Merged
merged 1 commit into from Aug 9, 2018

Conversation

Projects
None yet
2 participants
@normanmaurer
Member

normanmaurer commented Aug 8, 2018

…verSocketChannel.config().getOptions().

Motivation:

There is a JDK bug which will return IP_TOS as supported option for ServerSocketChannel even if its not supported afterwards and cause an AssertionError.
See http://mail.openjdk.java.net/pipermail/nio-dev/2018-August/005365.html.

Modifications:

Add a workaround for the JDK bug.

Result:

ServerSocketChannel.config().getOptions() will not throw anymore and work as expected.

Workaround JDK bug that will cause an AssertionError when calling Ser…
…verSocketChannel.config().getOptions().

Motivation:

There is a JDK bug which will return IP_TOS as supported option for ServerSocketChannel even if its not supported afterwards and cause an AssertionError.
See http://mail.openjdk.java.net/pipermail/nio-dev/2018-August/005365.html.

Modifications:

Add a workaround for the JDK bug.

Result:

ServerSocketChannel.config().getOptions() will not throw anymore and work as expected.
@normanmaurer

This comment has been minimized.

Show comment
Hide comment
@normanmaurer
Member

normanmaurer commented Aug 8, 2018

@normanmaurer

This comment has been minimized.

Show comment
Hide comment
@normanmaurer

normanmaurer Aug 9, 2018

Member

@meshcow also verified the fix... merging

Member

normanmaurer commented Aug 9, 2018

@meshcow also verified the fix... merging

@normanmaurer normanmaurer merged commit 534de73 into 4.1 Aug 9, 2018

1 check passed

continuous-integration/teamcity Finished TeamCity Build pull requests :: netty : Tests passed: 13855, ignored: 128
Details

@normanmaurer normanmaurer deleted the assertion_error_jdk_bug_workaround branch Aug 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment