New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly detect and handle CNAME loops. #8691

Merged
merged 1 commit into from Jan 14, 2019

Conversation

@normanmaurer
Copy link
Member

normanmaurer commented Dec 27, 2018

Motivation:

We do not correctly detect loops when follow CNAMEs and so may try to follow it without any success.

Modifications:

  • Correctly detect CNAME loops
  • Do not cache CNAME entries which point to itself
  • Add unit test.

Result:

Fixes #8687.

@normanmaurer

This comment has been minimized.

Copy link
Member Author

normanmaurer commented Dec 27, 2018

Fix was verified by @slggamerTrue.

Correctly detect and handle CNAME loops.
Motivation:

We do not correctly detect loops when follow CNAMEs and so may try to follow it without any success.

Modifications:

- Correctly detect CNAME loops
- Do not cache CNAME entries which point to itself
- Add unit test.

Result:

Fixes #8687.

@normanmaurer normanmaurer force-pushed the cname_loop branch from 66fcc2e to 21500e8 Jan 14, 2019

@normanmaurer normanmaurer merged commit 82ec6ba into 4.1 Jan 14, 2019

1 check was pending

pull request validation (centos6-java9) Build started for merge commit.
Details

@normanmaurer normanmaurer deleted the cname_loop branch Jan 14, 2019

normanmaurer added a commit that referenced this pull request Jan 14, 2019

Correctly detect and handle CNAME loops. (#8691)
Motivation:

We do not correctly detect loops when follow CNAMEs and so may try to follow it without any success.

Modifications:

- Correctly detect CNAME loops
- Do not cache CNAME entries which point to itself
- Add unit test.

Result:

Fixes #8687.

@normanmaurer normanmaurer added the defect label Jan 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment