New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only handle NXDOMAIN as failure when nameserver is authoritive or no … #8731

Merged
merged 1 commit into from Jan 18, 2019

Conversation

Projects
None yet
3 participants
@normanmaurer
Copy link
Member

normanmaurer commented Jan 18, 2019

…other nameservers are left.

Motivation:

When using multiple nameservers and a nameserver respond with NXDOMAIN we should only fail the query if the nameserver in question is authoritive or no nameservers are left to try.

Modifications:

  • Try next nameserver if NXDOMAIN was returned but the nameserver is not authoritive
  • Adjust testcase to respect correct behaviour.

Result:

Fixes #8261

Only handle NXDOMAIN as failure when nameserver is authoritive or no …
…other nameservers are left.

Motivation:

When using multiple nameservers and a nameserver respond with NXDOMAIN we should only fail the query if the nameserver in question is authoritive or no nameservers are left to try.

Modifications:

- Try next nameserver if NXDOMAIN was returned but the nameserver is not authoritive
- Adjust testcase to respect correct behaviour.

Result:

Fixes #8261
@normanmaurer

This comment has been minimized.

Copy link
Member Author

normanmaurer commented Jan 18, 2019

Special thanks to @Lukasa for discussion on the topic :)

@normanmaurer normanmaurer added this to the 4.1.33.Final milestone Jan 18, 2019

@normanmaurer normanmaurer self-assigned this Jan 18, 2019

@normanmaurer normanmaurer added the defect label Jan 18, 2019

@mrniko

This comment has been minimized.

Copy link

mrniko commented Jan 18, 2019

I confirm that it fixes #8261

@normanmaurer

This comment has been minimized.

Copy link
Member Author

normanmaurer commented Jan 18, 2019

@netty-bot test this please

@normanmaurer

This comment has been minimized.

Copy link
Member Author

normanmaurer commented Jan 18, 2019

@netty-bot test this please

@normanmaurer normanmaurer merged commit df5eb06 into 4.1 Jan 18, 2019

4 checks passed

pull request validation (centos6-java11) Build finished.
Details
pull request validation (centos6-java12) Build finished.
Details
pull request validation (centos6-java8) Build finished.
Details
pull request validation (centos6-java9) Build finished.
Details

@normanmaurer normanmaurer deleted the dns_nxdomain branch Jan 18, 2019

normanmaurer added a commit that referenced this pull request Jan 18, 2019

Only handle NXDOMAIN as failure when nameserver is authoritive or no …
…other nameservers are left. (#8731)

Motivation:

When using multiple nameservers and a nameserver respond with NXDOMAIN we should only fail the query if the nameserver in question is authoritive or no nameservers are left to try.

Modifications:

- Try next nameserver if NXDOMAIN was returned but the nameserver is not authoritive
- Adjust testcase to respect correct behaviour.

Result:

Fixes #8261
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment