Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't deregister Channel as part of closing it when using native kque… #8881

Merged
merged 1 commit into from Feb 25, 2019

Conversation

@normanmaurer
Copy link
Member

normanmaurer commented Feb 22, 2019

…ue transport

Motivation:

In #8665 we changed how we handle the registration of Channels to KQueue but missed to removed some code which would deregister the Channel before it actual closed the underlying socket. This could lead to have events triggered still while not have a mapping to the Channel anymore.

Modifications:

Remove deregister call during socket closure.

Result:

Fixes #8849.

…ue transport

Motivation:

In #8665 we changed how we handle the registration of Channels to KQueue but missed to removed some code which would deregister the Channel before it actual closed the underlying socket. This could lead to have events triggered still while not have a mapping to the Channel anymore.

Modifications:

Remove deregister call during socket closure.

Result:

Fixes #8849.
@normanmaurer

This comment has been minimized.

Copy link
Member Author

normanmaurer commented Feb 25, 2019

This was reported to fix the issue of @kachayev and @amizurov so let me merge this as it is just code removal

@normanmaurer normanmaurer merged commit d02b519 into 4.1 Feb 25, 2019
3 checks passed
3 checks passed
pull request validation (centos6-java11) Build finished.
Details
pull request validation (centos6-java8) Build finished.
Details
pull request validation (centos6-java9) Build finished.
Details
@normanmaurer normanmaurer added this to the 4.1.34.Final milestone Feb 25, 2019
@normanmaurer normanmaurer self-assigned this Feb 25, 2019
@normanmaurer normanmaurer added the defect label Feb 25, 2019
@normanmaurer normanmaurer deleted the kqueue_fd_fix branch Feb 25, 2019
normanmaurer added a commit that referenced this pull request Feb 25, 2019
…ue transport (#8881)

Motivation:

In #8665 we changed how we handle the registration of Channels to KQueue but missed to removed some code which would deregister the Channel before it actual closed the underlying socket. This could lead to have events triggered still while not have a mapping to the Channel anymore.

Modifications:

Remove deregister call during socket closure.

Result:

Fixes #8849.
Copy link
Member

carl-mastrangelo left a comment

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.