Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DefaultHeaders#valueIterator to support removal #9063

Merged
merged 3 commits into from Apr 16, 2019

Conversation

Projects
None yet
2 participants
@Scottmitch
Copy link
Member

commented Apr 16, 2019

Motivation:
While iterating values it is often desirable to be able to remove individual
entries. The existing mechanism to do this involves removal of all entries and
conditional re-insertion which is heavy weight in order to remove a single
value.

Modifications:

  • DefaultHeaders$ValueIterator supports removal

Result:
It is possible to remove entries while iterating the values in DefaultHeaders.

DefaultHeaders#valueIterator to support removal
Motivation:
While iterating values it is often desirable to be able to remove individual
entries. The existing mechanism to do this involves removal of all entries and
conditional re-insertion which is heavy weight in order to remove a single
value.

Modifications:
- DefaultHeaders$ValueIterator supports removal

Result:
It is possible to remove entries while iterating the values in DefaultHeaders.

@Scottmitch Scottmitch requested a review from normanmaurer Apr 16, 2019

@normanmaurer
Copy link
Member

left a comment

LGTM... merge away once it passed

@normanmaurer normanmaurer added this to the 4.1.35.Final milestone Apr 16, 2019

@normanmaurer normanmaurer merged commit 1d9090a into netty:4.1 Apr 16, 2019

3 checks passed

pull request validation (centos6-java11) Build finished.
Details
pull request validation (centos6-java12) Build finished.
Details
pull request validation (centos6-java8) Build finished.
Details
@normanmaurer

This comment has been minimized.

Copy link
Member

commented Apr 16, 2019

@Scottmitch thanks a lot...

normanmaurer added a commit that referenced this pull request Apr 16, 2019

DefaultHeaders#valueIterator to support removal (#9063)
Motivation:
While iterating values it is often desirable to be able to remove individual
entries. The existing mechanism to do this involves removal of all entries and
conditional re-insertion which is heavy weight in order to remove a single
value.

Modifications:
- DefaultHeaders$ValueIterator supports removal

Result:
It is possible to remove entries while iterating the values in DefaultHeaders.

@Scottmitch Scottmitch deleted the Scottmitch:headers_value_remove branch Apr 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.